vector-engineering / covidcg

A COVID-19 CoV Genetics (CG) browser to inform therapeutics development
https://covidcg.org
MIT License
26 stars 5 forks source link

Per-service installation: example bash script to launch flask server should have export commands #382

Closed monkollek closed 3 years ago

monkollek commented 3 years ago

When you run this script it fails. When you point export command it works. https://github.com/vector-engineering/covidcg/blob/master/services/server/serve.sh#L2-L4

Also there should be mention of specify CONFIGFILE somewhere with the test on launching flask server as the default is hardcoded in https://github.com/vector-engineering/covidcg/blob/master/services/server/cg_server/config.py#L21

atc3 commented 3 years ago

Thanks for the feedback, this should be fixed by #384. Let me know if you are still having issues with the per-service deployment of the flask server