search

vector-engineering / covidcg

A COVID-19 CoV Genetics (CG) browser to inform therapeutics development
https://covidcg.org
MIT License
26 stars 5 forks source link

Custom Sequence Select Tooltip Fix #422

Closed a13xk13m closed 3 years ago

a13xk13m commented 3 years ago

Fixed tooltips in the Select Sequences Modal. Two things were done: in the QuestionButton component that the user mouses over that activates the tooltip, useEffect was added. Inside of this .rebuild() is called if the prop rebuild is true (false by default). This allows us to only rebuild when they are actually viewed instead of rebuilding every tooltip when there is a mode change. It is important to note that .rebuild() needs to be called after the component has rendered, which seems backward. Secondly, the data-tip prop that is passed to ReactTooltip only works with main-tooltip right now. Might want to delete changes to docker-compose.yml and main.py in the commit as those are the changes to CORS and somehow ended up in this commit.

atc3 commented 3 years ago

Can you try rebasing this branch to the current master with git rebase? The CORS fixes are merged in and should be diff'd out.

I also added you as a collaborator, so you can push branches directly onto the main repo now