search

vector-engineering / covidcg

A COVID-19 CoV Genetics (CG) browser to inform therapeutics development
https://covidcg.org
MIT License
26 stars 5 forks source link

Question Button Fix #427

Closed a13xk13m closed 3 years ago

a13xk13m commented 3 years ago

Previous QuestionButton tooltip fix wasn't working in some places and needed to have its props refactored. If this happens with other tooltips in the future, add rebuild='rebuild' as a prop to the QuestionButton component and it should be fixed.

atc3 commented 3 years ago

Had an idea about why this might be happening – the rebuild prop could be reserved in some way for it to be directly injected into the real DOM. Maybe change the name of the prop to rebuildAfterMount or something more specific that won't clash with some reserved HTML keyword

a13xk13m commented 3 years ago

@atc3 Hit the nail on the head, using rebuildAfterMount instead of rebuild works flawlessly. Thank you! Closes #422