Fixed warnings on GCC/Clang

vector-of-bool / cmrc

A Resource Compiler in a Single CMake Script

MIT License

672 stars 74 forks source link

Fixed warnings on GCC/Clang #19

Closed marcizhu closed 4 years ago

marcizhu commented 4 years ago

This PR fixes two implicit conversion warnings, and it does not change the behaviour of the other code. This might be useful to users who use -Werror or users who find it anoying to get some warnings everytime they recompile their resources.

By the way, good job! This module is amazing and it has been helpful many times. Thanks for sharing this :D

marcizhu commented 4 years ago

@vector-of-bool any updates? Can this be merged into the main repo?

vector-of-bool commented 4 years ago

Hello! I'm so sorry that this took so long. I don't know how I never even saw it :disappointed:. This looks fine to merge, and I should have looked into conversion warnings from the beginning..

marcizhu commented 4 years ago

I'm so sorry that this took so long. I don't know how I never even saw it

No worries!! Thanks a lot for the merge. And thank you for such a great module!