vector-of-bool / cmrc

A Resource Compiler in a Single CMake Script
MIT License
672 stars 74 forks source link

Can you provide an install target on top level CMakelists.txt #23

Open Petross404 opened 4 years ago

Petross404 commented 4 years ago

Hello and well done on your excellent and hard work. I find this cmake module very usefull and I want to install it system-wide on my Gentoo with an ebuild. Perphaps pimp the ebuild into the Portage tree.

But the ebuild failed in install phase with this:

OUTPUT(tests/whence elf64-x86-64)
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: total time in link: 0.143828
>>> Source compiled.
>>> Test phase [not enabled]: dev-cpp/cmrc-2.0.1

>>> Install dev-cpp/cmrc-2.0.1 into /mnt/Volume_3/Gentoo/temp/portage/dev-cpp/cmrc-2.0.1/image
>>> Working in BUILD_DIR: "/mnt/Volume_3/Gentoo/temp/portage/dev-cpp/cmrc-2.0.1/work/cmrc-2.0.1_build"
ninja: error: unknown target 'install'
 * ERROR: dev-cpp/cmrc-2.0.1::testing failed (install phase):
 *   died running ninja install
 * 
 * Call stack:
 *     ebuild.sh, line  125:  Called src_install
 *   environment, line 2183:  Called cmake-utils_src_install
 *   environment, line  974:  Called die
 * The specific snippet of code:
 *       DESTDIR="${D}" ${CMAKE_MAKEFILE_GENERATOR} install "$@" || die "died running ${CMAKE_MAKEFILE_GENERATOR} install";
 * 

So, could you provide an install target for the module and/or the examples? Thank you very much.

justusranvier commented 12 months ago

It's nice that a vcpkg port is available but would be nicer if that wasn't the only option.

Looks like the pull request which added the install target was just left open for almost a year with no feedback or resolution before the submitter gave up so that doesn't look promising for this feature.