search

vector-of-bool / vscode-gitflow

Gitflow integration for Visual Studio Code
90 stars 22 forks source link

Workspace support #38

Closed anhthang closed 4 years ago

anhthang commented 4 years ago

Adding workspace support for this extension. It's showing workspace folder pick before any commands.

image

This PR to resolve the issue here: https://github.com/vector-of-bool/vscode-gitflow/issues/20

ghost commented 4 years ago

Bildschirmfoto 2020-05-08 um 16 10 11 in general, I have a repository already selected in my source-control tab, any chance to se this (as preset) ? Thanks Rolf

anhthang commented 4 years ago

@rolfschau do you want to apply git-flow for the selected repo in the source control tab? what I should do if multiple repositories are selected?

ghost commented 4 years ago

Am 08.05.2020 um 17:44 schrieb Anh Thang notifications@github.com:

@rolfschau https://github.com/rolfschau do you want to apply git-flow for the selected repo in the source control tab? what I should do if multiple repositories are selected?

that was the idea. I wasn't aware, that you can select more than one repo in this tab (doesn't make sense to me), so I see your problem. So having a inout (or select) field is ok too.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vector-of-bool/vscode-gitflow/pull/38#issuecomment-625878341, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZ5INSK5VMWRQV43HOTALRQQSGDANCNFSM4M4FQ4MQ.

phatmann commented 4 years ago

The Github extension uses the currently selected repo and does not ask you to choose a folder. I prefer that, but I am 100% ok with your approach to prompt for folder.

Note that a workspace folder can have more than one repo, but you can ignore this edge case for now, as the proposed functionality is a big step forward.

anhthang commented 4 years ago

yea, now I can see more thing to do for this feature:

anhthang commented 4 years ago

Since this repo and developer is inactivated for 2 years, I published a new extension here: https://marketplace.visualstudio.com/items?itemName=buianhthang.gitflow to maintain. If you still got errors, let me know and I will fix it.

I will close this PR now.

ghost commented 4 years ago

hi,

works for me after first trial. Thanks a lot.

Am 11.05.2020 um 12:11 schrieb Anh Thang notifications@github.com:

Since this repo and developer is inactivated for 2 years, I published a new extension here: https://marketplace.visualstudio.com/items?itemName=buianhthang.gitflow https://marketplace.visualstudio.com/items?itemName=buianhthang.gitflow to maintain. If you still got errors, let me know and I will fix it.

I will close this PR now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vector-of-bool/vscode-gitflow/pull/38#issuecomment-626608977, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZ5IJP7EDDDIBVVCZOGRTRQ7FONANCNFSM4M4FQ4MQ.

Mit freundlichen Grüßen Dipl. Ing. Rolf Schaufelberger Geschäftsführer

plusW GmbH Stuttgarterstr. 26 73635 Rudersberg

T +49 (0)7183 42 79 830 F +49 (0)7181 42 79 708 rs@plusw.de www.plusw.de

Sitz der Gesellschaft: plusW GmbH, Stuttgarterstr. 26, 73635 Rudersberg, Deutschland Geschäftsführer: Dipl. Ing. Rolf Schaufelberger Amts- und Registergericht: Stuttgart, HRB 725960 Umsatzsteuer-ID: DE 814 966 81