search

vector76 / gridfinity_openscad

MIT License
286 stars 51 forks source link

allows partial-width label #13

Closed benzvan closed 2 years ago

benzvan commented 2 years ago

This is a small update that allows the label tap in the basic_cup module to be partial-width instead of true or false.

benzvan commented 2 years ago

Let me know if this option interests you. I found it very useful for single-width cups for things like pencils and soapstones. The label tap makes a great spot to pick up the whole cup but doesn't get in the way of using the cup.

vector76 commented 2 years ago

Interesting. At first glance I like this. Let me think on it and I'll probably merge tomorrow.

vector76 commented 2 years ago

I think I will touch this up a bit afterward because it is getting to the point where positional arguments are not really viable and all the optional parameters need to be specified by keywords. So I'll probably add comments to that effect and adopt that policy internally where e.g. on line 49 the partitioned cavity should specify everything by keyword. Otherwise these sorts of changes will break existing code (or the parameters have to be added at the end, which is not much better).