Closed mrmattmorris closed 1 year ago
Whoops, this is already underway as PR#20. Consider this a vote in support.
Thank you. This has been implemented by #20 but I haven't had a chance to review and merge it. I am guessing will probably be accepting that PR but if you have some commentary, since you have been considering the same issue, I would be interested to hear it.
Thanks, I will close this issue as essentially duplicate.
I've reviewed PR#20. Ostat's logic and computations appear consistent with mine. His is a superior implementation.
Since this is my first contribution, I might add that this is an excellent implementation of Zack's work in OpenSCAD. It fixes all of the issues that I'm aware of with Zack's F360 model. Nice work.
The labeling shelves serve two purposes: 1) holding labels; and 2) acting as a finger catch to lift bins up when they're surrounded by adjacent bins. As currently implemented, label shelves are always 'left- or right-justified'. This makes it a bit awkward to lift wide bins that use short label shelves -- where the lift is happening away from the center of mass.
It could be useful to offer a option to center the label shelves for users who would prefer 'center justification'.
I've already implemented these changes to gridfinity_cup_modules.scad. I can make a pull request if the owner is interested.