search

vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
106 stars 91 forks source link

The `role` value should align with the roles in our documentation #194

Open binarylogic opened 2 years ago

binarylogic commented 2 years ago

Currently the role value accepts Agent, Aggregator, and Stateless-Aggregator. If possible, we should update this to reflect the two roles that we are communicating in the docs: Agent and Aggregator. A stateful/stateless aggregator is just a type an aspect of the Aggregator role and should be controlled by a separate value (i.e., stateful or persistent_disk).

This is a small tweak but will help unify the experience across our installation d

spencergilbert commented 2 years ago

To clarify here - Aggregator vs Stateless-Aggregator not only affects the presence of a PersistentVolume but also https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#using-statefulsets

The proposed new value would also make this overall change, correct?