vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
111 stars 90 forks source link

fix(vector): no need to set replicas to statefulset when using hpa #203

Closed CasparChou closed 2 years ago

CasparChou commented 2 years ago

as title, deploymentset has an if condition but statefulset doesn't have, but I think this is the same thing when using autoscaling

spencergilbert commented 2 years ago

Could you bump the chart version to 0.10.2 and rerun helm-docs as well?

CasparChou commented 2 years ago

sorry for missing the chart version helm-docs seems no change in this pr

Should I modify CHANGELOG.md and README.md?

spencergilbert commented 2 years ago

Looks perfect, thanks! I'll look to get this published shortly.