vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
111 stars 90 forks source link

feat(vector): add RBAC to list and watch nodes #211

Closed nabokihms closed 2 years ago

nabokihms commented 2 years ago

The ability to list and watch nodes will be required to annotate logs from kubernetes_logs sources in the future.

See https://github.com/vectordotdev/vector/pull/12730 for more details.

spencergilbert commented 2 years ago

As a nit - I think we should bump the minor version and have this as a feat, as it's adding new functionality.

Thanks for the update!

spencergilbert commented 2 years ago

More nitpicking 😓 could you edit commit as well so it makes it into the changelog as a feat rather than a fix?

nabokihms commented 2 years ago

Sorry, my bad. It should be ok now.