vector _pod.tpl does not allow hostNetwork

vectordotdev / helm-charts

Helm charts for Vector.

https://vector.dev

Mozilla Public License 2.0

111 stars 90 forks source link

vector _pod.tpl does not allow hostNetwork #213

Closed mdaniel closed 2 years ago

mdaniel commented 2 years ago

For clusters with --http-put-response-hop-limit 1 on purpose, we need to run vector with hostNetworking: true so it can run the aws_ec2_metadata transform without exposing IMDSv2 to the workload Pods

The current _pod.tpl does not offer .Values.hostNetwork or such that would allow the chart to be installed in that configuration

spencergilbert commented 2 years ago

I think I've always seen us recommend upping the hop-limit, but I'm sure there's cases where that's not desired.

Easy to add in, happy to review a contribution otherwise I've added it to our backlog!

rgl commented 2 years ago

@spencergilbert please take a look at #238 and let me known if something is missing :-)