search

vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
106 stars 91 forks source link

chore(deps): Update haproxy-alpine to 2.4.17 #218

Closed SIPR-octo closed 2 years ago

SIPR-octo commented 2 years ago

Fixes #217

See the linked issue for more details

spencergilbert commented 2 years ago

Thanks @SIPR-octo do you mind also bumping the patch version and running helm-docs to update the README banner?

SIPR-octo commented 2 years ago

@spencergilbert Just did!

SIPR-octo commented 2 years ago

I just updated the Chart version to make the CI jobs pass. Do I need to update the README as well?

Unsure to what extend I need to modify this, I did not find any CONTRIBUTING.md file :)

spencergilbert commented 2 years ago

Unsure to what extend I need to modify this, I did not find any CONTRIBUTING.md file :)

😅 https://github.com/vectordotdev/helm-charts/issues/204

I've got it - it's normally just been myself making changes so I haven't prioritized a lot of documentation

SIPR-octo commented 2 years ago

Just upgraded helm-docs version in CI because it seems you generated the doc with a newer version than the one used in GitHub Actions (tested locally, it works).

I can make 2 separate MR if you wish me to (1 for bumping helm-docs, 1 for haproxy), just let me know.