search

vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
111 stars 90 forks source link

Reintroduce `base` for image config #237

Closed onedr0p closed 4 months ago

onedr0p commented 2 years ago

Hi 👋🏼

I saw this was removed with the switch to the new vector chart. I am running vector agent with the debian flavor of the image because it includes journalctl

image:
  repository: timberio/vector
  tag: 0.23.3-debian

It would be nice if we could set a flavor or base config defining the image type we want to use:

image:
  repository: timberio/vector
  base: debian # or flavor: debian

The reason I see this being helpful is that as a consumer of the chart when I go to update the chart version, I also need to update the values.yaml file with the new vector image. It would be nice to only care about the chart version instead of the chart version and image tag.

Thanks!

spencergilbert commented 2 years ago

👋 Hey, I'd be happy to merge in a PR that add's support for this - as long as the existing values still work and we can pull in the tag from Chart.yaml

pdonorio commented 1 month ago

Is this working? I'm trying to use base (to use alpine) and not tag and the end result is distroless 🤔

version 0.33.0

jszwedko commented 1 month ago

Is this working? I'm trying to use base (to use alpine) and not tag and the end result is distroless 🤔

version 0.33.0

Can you provide the values.yaml file you are using?

pdonorio commented 1 month ago

Don't think I can share the full version @jszwedko , but the relevant one is just

this bit doesn't work

image:
  base: "alpine"

this version does work perfectly

image:
  tag: 0.40.X-alpine
jszwedko commented 4 weeks ago

Ah, actually @pdonorio , this was added in v0.34.0 of the chart. Do you mind trying that (or newer)?

pdonorio commented 3 weeks ago

Updated to latest https://github.com/vectordotdev/helm-charts/releases/tag/vector-0.35.1

It really seems to work with

image:
  base: "alpine"

New pods have image timberio/vector:0.40.1-alpine