search

vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
104 stars 90 forks source link

feat(vector): :sparkles: add envFrom support #246

Closed dannylongeuay closed 1 year ago

dannylongeuay commented 1 year ago

Closes #214

dannylongeuay commented 1 year ago

@spencergilbert do you have any cycles to review this?

spencergilbert commented 1 year ago

👍 yep, should be able to get to it this week

dannylongeuay commented 1 year ago

+1 CI works! Thanks for the contribution, I tweaked the comment/doc slightly since envFrom can be used with either Secrets or ConfigMaps and I wanted to make sure that was clear - what do you think?

No problem, this will make my life much easier! I like the change and commited it!

spencergilbert commented 1 year ago

I wish the "approve and run ci" button just worked for the entire PR, and not on every change 😭

Thanks again for the contribution @dannylongeuay!