search

vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
104 stars 90 forks source link

Separate annotations for headless vector service #267

Open trexx opened 1 year ago

trexx commented 1 year ago

Hi,

We use External DNS annotations to publish DNS records for the vector service. It seems the headless service is also getting the same annotation causing extraneous and useless DNS records to be published.

Would a PR be welcome to separate the two?

spencergilbert commented 1 year ago

👋

Hey, I actually looked at this recently but couldn't land on a UX I liked while working on https://github.com/vectordotdev/helm-charts/pull/257. If I recall correctly, I wasn't able to find a nice way to avoid users from having to duplicate labels/annotations if they did want the same across both services.

datsabk commented 1 year ago

@spencergilbert - Why not just have a single service and allow definition of type for it ?

OR

Allow users to have array of services ?

spencergilbert commented 1 year ago

Hey @datsabk - do you have an example of what that would look like?