vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
104 stars 90 forks source link

feat(vector): add default all tolerations #272

Closed hawkesn closed 1 year ago

hawkesn commented 1 year ago

Relates to: https://github.com/vectordotdev/helm-charts/issues/271 Adding default tolerations to the daemon set.

spencergilbert commented 1 year ago

Hi @hawkesn I left a comment on the issue you opened for the larger discussion, specifically for this change though...

I believe this would be the default regardless of the defined role, if we went forward with this I think we'd want only the Agent role to have this toleration.

hawkesn commented 1 year ago

Closing based on discussion