vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
104 stars 90 forks source link

Enable reloading of config for aggregator #281

Closed sinacek closed 1 year ago

sinacek commented 1 year ago

Enable reloading of config for aggregator when config file is changed without restart of pod.

Notes:

jszwedko commented 1 year ago

Hey @sinacek !

Would you be able to provide a bit more detail about what you are trying to accomplish? Is it that you want to use https://github.com/jimmidyson/configmap-reload with Vector to reload when the config map changes? If so, it should work once that tool supports sending SIGHUPs, which seems to be on its roadmap.

If that's not what you want, could you provide a bit more detail about your use-case?

sinacek commented 1 year ago

Hi @jszwedko , that is exactly how you described. Roadmap of which project do you mean?

jszwedko commented 1 year ago

Hi @jszwedko , that is exactly how you described. Roadmap of which project do you mean?

The roadmap of the https://github.com/jimmidyson/configmap-reload project. It looks like they aim to support sending SIGHUPs in the future which means it'll just work with Vector. Assuming that is what you want, I think we can close this issue and just wait for them to add it (https://github.com/jimmidyson/configmap-reload/issues/23).

sinacek commented 1 year ago

That issue is 5 years old, so i'm not sure if he has plan to implement it. Do you have on road map add endpoint to reload as it has prometheus?

jszwedko commented 1 year ago

We don't have plans for that at the moment, but if it'd be useful for you would you want to open a feature request on the Vector repository describing what you would need? https://github.com/vectordotdev/vector/issues/new?assignees=&labels=type%3A+feature&template=feature.yml

sinacek commented 1 year ago

I find that similar issue is already exists, so I send comment there https://github.com/vectordotdev/vector/issues/541