search

vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
103 stars 89 forks source link

Remap `host` to the node name for Agent `host_metrics` #307

Closed sdwilsh closed 1 year ago

sdwilsh commented 1 year ago

The current behavior of the chart provides pod names of the agent to Prometheus, which isn't very helpful for host metrics. This change is a much better default behavior, at least in my novice opinion.

spencergilbert commented 1 year ago

This feels like a good change - but it would be a breaking change, which we haven't done with this chart yet (IIRC).

jszwedko commented 1 year ago

We have made a couple of breaking changes: https://github.com/vectordotdev/helm-charts/blob/develop/CHANGELOG.md

Is the current behavior also potentially what some users will want? Maybe we could make it a flag?

spencergilbert commented 1 year ago

Thinking about this - I'm not sure this is the best way to resolve. It would only apply the a default configuration, and any user-end changes would drop the use of the proper host(node)name.

Ultimately I think this should be solved in Vector itself, rather than as a step in VRL. Perhaps a short term, non-breaking change, would be documenting this VRL program as an example in the README?

spencergilbert commented 1 year ago

I'm going to close this PR, given my thoughts above. I'd be happy to merge in a note in the documentation about this though.