Add annotations to Vector's HPA

vectordotdev / helm-charts

Helm charts for Vector.

https://vector.dev

Mozilla Public License 2.0

103 stars 89 forks source link

Add annotations to Vector's HPA #336

Closed namm2 closed 7 months ago

namm2 commented 8 months ago

Allowing to add annotations to the Vector's HPA, this is needed when someone want to use kube-metrics-adapter

dsmith3197 commented 7 months ago

Hi @namm2, could you merge main? One of the CI jobs is broken on this branch but fixed on main. Thank you!

jszwedko commented 7 months ago

I think this PR should have included:

A CHANGELOG entry
A bump to the chart version

jszwedko commented 7 months ago

Ah, I see CI didn't flag these lacks because the PR title was not using the semantic PR format (enhancement(vector): ...). We should be enforcing that. I opened https://github.com/vectordotdev/helm-charts/issues/344 to track.