search

vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
102 stars 89 forks source link

fix(vector): add minReadySeconds to StatefulSet and Deployment specs #367

Closed alexanderldavis closed 4 months ago

alexanderldavis commented 4 months ago

The chart currently supports minReadySeconds for DaemonSet-based deployments of the Vector agent. This PR extends this value to also apply to StatefulSets and Deployment specs.

jszwedko commented 4 months ago

@alexanderldavis it looks like there are some CI failures here when you get some time.

alexanderldavis commented 4 months ago

@jszwedko I'm struggling to find a good way to pass the linter for older kube versions. minReadySeconds was added to Statefulsets in v1.22, but made generally available in v1.25. Do you have a recommendation for how that should be handled?

jszwedko commented 4 months ago

@alexanderldavis I was expecting the failing CI checks to block the automerge but apparently they didn't 😓 I opened https://github.com/vectordotdev/helm-charts/pull/371 to revert.

minReadySeconds was added to Statefulsets in v1.22, but made generally available in v1.25

My assumption would be that we'd only want to template it out for v1.25+ then, but maybe I'm missing something 🤔