search

vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
111 stars 90 forks source link

mountpoints instead of mountPoints #376

Closed jonathanlking closed 6 months ago

jonathanlking commented 6 months ago

I believe these should both be mountpoints instead of mountPoints:

https://github.com/vectordotdev/helm-charts/blob/afdcb836f2004eed7197b105d777c9fd3698c28f/charts/vector/templates/configmap.yaml#L72 https://github.com/vectordotdev/helm-charts/blob/afdcb836f2004eed7197b105d777c9fd3698c28f/charts/vector/docs/Migrate_from_vector-agent.md?plain=1#L35

With the following config:

sources:
  host_metrics:
    filesystem:
      mountPoints:
        excludes:
        - '*/proc/sys/fs/binfmt_misc'
    type: host_metrics
sinks:
  blackhole:

Switching to mountpoints I get the diff (when passing through vector convert-config --output-format json):

63,66c63,66
<           "includes": [
<             "*"
<           ],
<           "excludes": null
---
>           "includes": null,
>           "excludes": [
>             "*/proc/sys/fs/binfmt_misc"
>           ]

This indicates mountPoints isn't being read from.

The documentation at https://vector.dev/docs/reference/configuration/sources/host_metrics/#warnings also refers to mountpoints and it would explain why I've still been getting the k8s "Too many levels of symbolic links" errors 😅

jonathanlking commented 6 months ago

I'm happy to open a PR for this if it would be helpful, but equally as it's such a small change it might just cause busywork.

jszwedko commented 6 months ago

Doh! Thanks for catching that @jonathanlking . I'd be happy to see a PR for it if you get the time. Otherwise we will circle back around to it.