search

vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
111 stars 90 forks source link

fix(vector): have psp support hostNetwork: true when podHostNetwork is true #385

Closed nascd closed 5 months ago

jszwedko commented 5 months ago

I think you just need to bump the chart version.

jszwedko commented 5 months ago

(pressed the wrong button 😓 )

nascd commented 5 months ago

I think you just need to bump the chart version.

Thanks @jszwedko, just a patch increment to https://github.com/vectordotdev/helm-charts/blob/develop/charts/vector/Chart.yaml#L3 ? Should I include that in this PR, or a follow-up after this is merged?

jszwedko commented 5 months ago

I think you just need to bump the chart version.

Thanks @jszwedko, just a patch increment to https://github.com/vectordotdev/helm-charts/blob/develop/charts/vector/Chart.yaml#L3 ? Should I include that in this PR, or a follow-up after this is merged?

Yeah, I think it would just be a patch bump. It'll have to be part of this PR to satisfy the linter 🙏

nascd commented 5 months ago

@jszwedko I've bumped the version. I don't appear to have permissions to merge, but please let me know if there's anything else I need to do. Thank you!

nascd commented 5 months ago

Is there something else required to get this chart available in the public repository?

jszwedko commented 5 months ago

Is there something else required to get this chart available in the public repository?

We are planning a release for next week so I think we can just loop it in with that.