search

vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
114 stars 89 forks source link

enhancement(vector): Allow external autoscaler #386

Closed srstrickland closed 6 months ago

srstrickland commented 6 months ago

When using any autoscaler, replicas should not be set on any Deployment or StatefulSet. This helm chart has hooks for defining an HPA, but there are times when users may want to create their own, or use something external like KEDA. In our case, we want to use KEDA for scaling based on kafka lag and other triggers. This largely works as expected, but I need to prevent the replicas field from being populated, or else things appear out-of-sync when the external autoscaler is doing its thing (we use ArgoCD and it will show the project as out-of-sync because of replicas).

The feature here is just to offer an additional field under autoscaling options: external: true/false.

srstrickland commented 6 months ago

Ah, great... will do. Should I put in a note in the CHANGELOG.md as well? Side note: I see the current chart version is 0.32.2, but only 0.32.1 has been produced (and no note in changelog about 0.32.2). So I wasn't sure if you had an external release cycle. Let me know, happy to update anything.

(also thx for fixing PR title 😄)

jszwedko commented 6 months ago

Ah, great... will do. Should I put in a note in the CHANGELOG.md as well? Side note: I see the current chart version is 0.32.2, but only 0.32.1 has been produced (and no note in changelog about 0.32.2). So I wasn't sure if you had an external release cycle. Let me know, happy to update anything.

Ah, I missed the version was updated in another PR. This is a feature addition rather than a bug fix, though, so we should update to 0.33.0 to follow semver. The changelog is generated during release, from commit titles, so you don't have to update that.

srstrickland commented 6 months ago

Any thoughts on when 0.33.0 will be published? It's not blocking me; I've published this update to our own internal repo, just would prefer to use the official one whenever it's available.

jszwedko commented 6 months ago

Any thoughts on when 0.33.0 will be published? It's not blocking me; I've published this update to our own internal repo, just would prefer to use the official one whenever it's available.

Should be this week!