search

vectordotdev / helm-charts

Helm charts for Vector.
https://vector.dev
Mozilla Public License 2.0
114 stars 89 forks source link

enhancement(vector): Update the image fields to allow for a static base name #388

Closed jandersen-plaid closed 6 months ago

jandersen-plaid commented 6 months ago

This fixes #237 by allowing the user of the chart to set a static .Values.image.base field.

When this is set, it will be used to replace the base that is used in the AppVersion where appropriate, so that users can upgrade their chart without having to constantly change the image tag to keep the version up.

The order of precedence for this is:

  1. .Values.image.tag overrides everything
  2. .Values.image.base overrides the base of the .Chart.AppVersion
  3. .Chart.AppVersion is the default

I could not for the life of me get chart testing to work locally for some reason, but I am happy to update the README.md by hand if necessary.

jszwedko commented 6 months ago

I'm curious what you saw when you ran helm-docs but I pushed a commit regenerating the README.md to satisfy CI.

jandersen-plaid commented 6 months ago

I'm curious what you saw when you ran helm-docs but I pushed a commit regenerating the README.md to satisfy CI.

I think my local setup is just a bit borked -- I will need to fix it later today, but I did not want to slow down on getting the PR up while I had the motivation and time. Thank you for the review!