search

vectordotdev / timber-elixir

🌲 Great Elixir logging made easy
https://timber.io
Other
214 stars 29 forks source link

Resolve Elixir 1.8.0 warnings #322

Closed binarylogic closed 5 years ago

binarylogic commented 5 years ago

Elixir 1.8.0 deprecates the plural time units, we should resolve the warnings that Timber emits across all Timber libraries:

warning: deprecated time unit: :milliseconds. A time unit should be :second, :millisecond, :microsecond, :nanosecond, or a positive integer
  (timber_ecto) lib/timber_ecto.ex:86: Timber.Ecto.log/2
  (odin_database) Odin.Database.Repo.__log__/1
  (db_connection) lib/db_connection.ex:1186: DBConnection.log/6
  (db_connection) lib/db_connection.ex:1167: DBConnection.transaction_log/1
  (db_connection) lib/db_connection.ex:1271: anonymous fn/3 in DBConnection.begin_meter/6
  (db_connection) lib/db_connection.ex:1283: DBConnection.transaction_run/4
  (db_connection) lib/db_connection.ex:1207: DBConnection.run_begin/3
  (db_connection) lib/db_connection.ex:798: DBConnection.transaction/3
  (ecto) lib/ecto/repo/schema.ex:125: Ecto.Repo.Schema.insert!/4
  test/integration/notification_destinations_test.exs:14: Odin.Services.Integration.NotificationDestinationsTest."test Odin.Services.NotificationDestinations.notify/2 Timber organizations notify admin only"/1
  (ex_unit) lib/ex_unit/runner.ex:355: ExUnit.Runner.exec_test/1
  (stdlib) timer.erl:166: :timer.tc/1
  (ex_unit) lib/ex_unit/runner.ex:306: anonymous fn/4 in ExUnit.Runner.spawn_test_monitor/4