Ensure request body contents are rewound

vectordotdev / timber-ruby

🌲 Great Ruby logging made easy.

https://timber.io

Other

154 stars 19 forks source link

Ensure request body contents are rewound #140

Closed binarylogic closed 7 years ago

binarylogic commented 7 years ago

We had a user report that a params[:file] value was empty due to not being rewound. I want to double check that Timber is not causing this, and add a test to ensure it is not.

binarylogic commented 7 years ago

For posterity, and to clarify for anyone watching this issue, the above PR fixes this by ignoring non-primitive parameter types. Rails represents uploaded file contents as a ActionDispatch::Http::UploadedFile object, which gets excluded accordingly.