vectordotdev / vector

A high-performance observability data pipeline.
https://vector.dev
Mozilla Public License 2.0
18.08k stars 1.59k forks source link

Health checks should retry #16810

Open jszwedko opened 1 year ago

jszwedko commented 1 year ago

A note for the community

Problem

Currently, Vector sink health checks only execute once at component start-up and, if they do not succeed, cause Vector to stop if --require-healthy is used. However, there can be transient errors (like https://github.com/vectordotdev/vector/issues/16578) that could be retried by Vector.

We could start with just applying the request options to health checks as well though I could also see users potentially wanting different sets of retry configuration for health checks. I'm also not sure that all sink health checks are request based.

Configuration

No response

Version

vector 0.28.1

Debug Output

No response

Example Data

No response

Additional Context

No response

References

pgassmann commented 1 year ago

That's the reason I had to disable the checks for loki sink.

BTW there's a typo in the title: Heath -> Health