Windows installer overwrites existing config/vector.yaml

jgresiak commented 2 months ago

A note for the community

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

Hello there,

During an update of the Windows client using the MSI (0.39.0), I realized that the installer had overwritten the existing config/vector.yaml.

My usual expectation during this update process is that any existing file is either left in peace (or way less commonly renamed) to avoid potential data loss of existing config.

Is this a bug or a feature?

Cheers <3

Configuration

No response

Version

vector 0.39.0 (x86_64-pc-windows-msvc 73da9bb 2024-06-17 16:00:23.791735272)

Debug Output

No response

Example Data

No response

Additional Context

No response

References

No response

jszwedko commented 2 months ago

Hi @jgresiak ! Thanks for filing this. I'm not super familiar with the Windows ecosystem so I'm not sure what is normal there, but I would personally find it to be unexpected so I think this is likely a bug.

jgresiak commented 2 months ago

Hey @jszwedko It's not really tied to Windows environment, just something I usually see with installers that leave existing data in place rather overwriting them. I don't know how the GNU/Linux installer does it, though.

vectordotdev / vector