HTTP Server source does not support OPTIONS request method

xiazuojie commented 3 weeks ago

A note for the community

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

Currently, http_server source supports DELETE, GET, HEAD, PATCH, POST, and PUT request methods. OPTIONS request method is somehow missing. We want vector's http server to handle CORS preflight request which uses OPTIONS request method.

[sources.http_options]
type = "http_server"
address = "0.0.0.0:8080"
encoding = "binary"
method = "OPTIONS"
strict_path = false

[sinks.blackhole]
type = "blackhole"
inputs = ["http_options"]
buffer.max_events = 1000
buffer.type = "memory"

Attempted Solutions

Add support of OPTIONS request method in the code.

Proposal

No response

References

No response

Version

0.40.1

jszwedko commented 3 weeks ago

Hi @xiazuojie !

Can you clarify if you mean you want either:

The http_server simply to OPTIONS requests with the valid request methods
The http_server to accept OPTIONS requests but then generate events based on them. If so, what content would you like to see in the event?

xiazuojie commented 2 weeks ago

Hi @xiazuojie !

Can you clarify if you mean you want either:

The http_server simply to OPTIONS requests with the valid request methods

The http_server to accept OPTIONS requests but then generate events based on them. If so, what content would you like to see in the event?

I mean option 2. The content should be the same as any other request methods. For OPTIONS request method, the http body is usually null but the headers and query params could be used.

vectordotdev / vector