jszwedko commented 1 day ago

We missed it for the aws-config crate which leads to a panic when the EcsContainer credentials provider is used. Some of the other additions are redundant since they just enable the feature on subpackages that we already enabled the feature on (like aws-smithy-runtime), but adding for completeness.

Ref: https://github.com/vectordotdev/vector/issues/20662#issuecomment-2368363337

datadog-vectordotdev[bot] commented 1 day ago

Datadog Report

Branch report: jszwedko/aws-rt-tokio Commit report: 493ca61 Test service: vector

:white_check_mark: 0 Failed, 7 Passed, 0 Skipped, 25.48s Total Time

github-actions[bot] commented 1 day ago

Regression Detector Results

Run ID: 3f5106a1-af43-430a-9630-e0bb8531d934 Metrics dashboard

Baseline: 65e71674095640e24ee03ecc0dbc643bd66b0113 Comparison: 7f376b12c7ab432009839938d1696c84601663a0

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

perf	experiment	goal	Δ mean %	Δ mean % CI	links
✅	socket_to_socket_blackhole	ingress throughput	+5.30	[+5.20, +5.40]

Experiments ignored for regressions

Regressions in experiments with settings containing `erratic: true` are ignored. | perf | experiment | goal | Δ mean % | Δ mean % CI | links | |------|-------------------|-------------------|----------|------------------|-------| | ❌ | file_to_blackhole | egress throughput | -20.92 | [-27.40, -14.45] | |

Fine details of change detection per experiment

| perf | experiment | goal | Δ mean % | Δ mean % CI | links | |------|---------------------------------------------------|--------------------|----------|------------------|-------| | ✅ | socket_to_socket_blackhole | ingress throughput | +5.30 | [+5.20, +5.40] | | | ➖ | otlp_http_to_blackhole | ingress throughput | +3.31 | [+3.17, +3.45] | | | ➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | +1.27 | [+1.11, +1.42] | | | ➖ | otlp_grpc_to_blackhole | ingress throughput | +1.25 | [+1.12, +1.38] | | | ➖ | splunk_hec_route_s3 | ingress throughput | +1.21 | [+0.89, +1.54] | | | ➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | +0.93 | [+0.82, +1.03] | | | ➖ | datadog_agent_remap_datadog_logs | ingress throughput | +0.48 | [+0.28, +0.68] | | | ➖ | http_to_http_acks | ingress throughput | +0.36 | [-0.86, +1.59] | | | ➖ | syslog_splunk_hec_logs | ingress throughput | +0.33 | [+0.20, +0.47] | | | ➖ | http_to_http_noack | ingress throughput | +0.10 | [+0.04, +0.17] | | | ➖ | http_text_to_http_json | ingress throughput | +0.04 | [-0.09, +0.17] | | | ➖ | http_to_http_json | ingress throughput | +0.03 | [-0.00, +0.07] | | | ➖ | datadog_agent_remap_blackhole_acks | ingress throughput | +0.03 | [-0.07, +0.13] | | | ➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | +0.02 | [-0.08, +0.11] | | | ➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | +0.02 | [-0.09, +0.13] | | | ➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | -0.01 | [-0.10, +0.09] | | | ➖ | http_to_s3 | ingress throughput | -0.10 | [-0.38, +0.17] | | | ➖ | datadog_agent_remap_blackhole | ingress throughput | -0.22 | [-0.35, -0.10] | | | ➖ | syslog_humio_logs | ingress throughput | -0.66 | [-0.81, -0.51] | | | ➖ | syslog_loki | ingress throughput | -0.85 | [-0.97, -0.74] | | | ➖ | syslog_log2metric_humio_metrics | ingress throughput | -0.89 | [-0.99, -0.79] | | | ➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | -0.90 | [-1.03, -0.77] | | | ➖ | fluent_elasticsearch | ingress throughput | -1.14 | [-1.63, -0.64] | | | ➖ | http_elasticsearch | ingress throughput | -1.21 | [-1.37, -1.05] | | | ➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | -1.36 | [-1.52, -1.19] | | | ❌ | file_to_blackhole | egress throughput | -20.92 | [-27.40, -14.45] | |

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI". For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true: 1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look. 2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that *if our statistical model is accurate*, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants. 3. Its configuration does not mark it "erratic".

vectordotdev / vector