vectordotdev / vector

A high-performance observability data pipeline.
https://vector.dev
Mozilla Public License 2.0
18.21k stars 1.6k forks source link

chore(ci): Add statuses write permission to workflows #21788

Closed jszwedko closed 1 week ago

jszwedko commented 1 week ago

Summary

Change Type

Is this a breaking change?

How did you test this PR?

Will need to test after this is merged.

Does this PR include user facing changes?

Checklist

References

Related:

datadog-vectordotdev[bot] commented 1 week ago

Datadog Report

Branch report: jszwedko/add-commit-statuses-to-triggered-workflows Commit report: f47d500 Test service: vector

:white_check_mark: 0 Failed, 7 Passed, 0 Skipped, 25.42s Total Time

pront commented 1 week ago

Hm, https://github.com/vectordotdev/vector/actions/runs/11823354692. I think it reads the workflow from master?

pront commented 1 week ago

After merging, this was triggered correctly via a review comment: https://github.com/vectordotdev/vector/actions/runs/11825931186/job/32950817911

jszwedko commented 1 week ago

Hm, https://github.com/vectordotdev/vector/actions/runs/11823354692. I think it reads the workflow from master?

Yeah, unfortunately the comment triggers use the workflow file from master making it difficult to test changes like these before they are merged.