chore(dev): delete 'configurable_package_name_hack' and refactor - Githubissues

vectordotdev / vector

A high-performance observability data pipeline.

https://vector.dev

Mozilla Public License 2.0

18.2k stars 1.6k forks source link

chore(dev): delete 'configurable_package_name_hack' and refactor #21826

Closed pront closed 3 days ago

pront commented 3 days ago

Summary

Removes a hacky workaround from macro expansions which caused problems with multiple IDEs.

Change Type

[ ] Bug fix
[ ] New feature
[x] Non-functional (chore, refactoring, docs)
[ ] Performance

Is this a breaking change?

[ ] Yes
[x] No

How did you test this PR?

Tests and CI.

Does this PR include user facing changes?

[ ] Yes. Please add a changelog fragment based on our guidelines.
[x] No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

[x] Please read our Vector contributor resources.
[x] If this PR introduces changes Vector dependencies (modifies Cargo.lock), please run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

datadog-vectordotdev[bot] commented 3 days ago

Datadog Report

Branch report: pront/delete-configurable-hacks Commit report: 1d4347d Test service: vector

:white_check_mark: 0 Failed, 7 Passed, 0 Skipped, 25.45s Total Time