vectordotdev / vector

A high-performance observability data pipeline.
https://vector.dev
Mozilla Public License 2.0
17.46k stars 1.53k forks source link

Add IPv6-related options to the `http` sink #2508

Open ghost opened 4 years ago

ghost commented 4 years ago

I propose to add new options to the configuration of the http sink which would allow the user to configure behavior of the sink when the target host is available on both IPv4 and IPv6 addresses.

For example, there might be two new options:

LucioFranco commented 4 years ago

This may be relevant https://github.com/hyperium/hyper/pull/1937

thameezb commented 1 year ago

Any update on this?

jszwedko commented 1 year ago

Any update on this?

Nothing yet, but could describe the use-case you have for this? E.g. do you just need the happy_eyeballs_timeout_ms setting? Something else?

thameezb commented 1 year ago

Any update on this?

Nothing yet, but could describe the use-case you have for this? E.g. do you just need the happy_eyeballs_timeout_ms setting? Something else?

Rereading the issue I might be at the incorrect location :)

We run an IPv6 EKS cluster, and would like to use vector in HTTP server mode (https://vector.dev/docs/reference/configuration/sources/http_server/). However seemingly it cannot listen on :: (we have tried :::PORT and [::]:PORT and both throw errors.

I had assumed this was enabling IPv6 support for the HTTP server source (but now realise its the sink)

jszwedko commented 1 year ago

Any update on this?

Nothing yet, but could describe the use-case you have for this? E.g. do you just need the happy_eyeballs_timeout_ms setting? Something else?

Rereading the issue I might be at the incorrect location :)

We run an IPv6 EKS cluster, and would like to use vector in HTTP server mode (https://vector.dev/docs/reference/configuration/sources/http_server/). However seemingly it cannot listen on :: (we have tried :::PORT and [::]:PORT and both throw errors.

I had assumed this was enabling IPv6 support for the HTTP server source (but now realise its the sink)

Ah, I see. What are the errors you are seeing? I tried it just now and was able to bind to [::]:8080 successfully. This seems to be unrelated to this issue so you could open a separate one or a discussion.

thameezb commented 1 year ago

Any update on this?

Nothing yet, but could describe the use-case you have for this? E.g. do you just need the happy_eyeballs_timeout_ms setting? Something else?

Rereading the issue I might be at the incorrect location :) We run an IPv6 EKS cluster, and would like to use vector in HTTP server mode (https://vector.dev/docs/reference/configuration/sources/http_server/). However seemingly it cannot listen on :: (we have tried :::PORT and [::]:PORT and both throw errors. I had assumed this was enabling IPv6 support for the HTTP server source (but now realise its the sink)

Ah, I see. What are the errors you are seeing? I tried it just now and was able to bind to [::]:8080 successfully. This seems to be unrelated to this issue so you could open a separate one or a discussion.

Thank you for the swift responses. Indeed it does work (and quite seamlessly I might add)

I decided to interact with the issue directly (vs going via the security team which was having the issue) and after much digging the issue is on our side, through the various terraform templating, matched with helm templating, until it hits the k8s configmap (missing quotes which meant the [::]:PORT was not being read correctly

jszwedko commented 1 year ago

I decided to interact with the issue directly (vs going via the security team which was having the issue) and after much digging the issue is on our side, through the various terraform templating, matched with helm templating, until it hits the k8s configmap (missing quotes which meant the [::]:PORT was not being read correctly

Aha! Glad you sorted it out!