vectordotdev / vrl

Vector Remap Language
Mozilla Public License 2.0
136 stars 68 forks source link

fix(convert): return error when conversion exceeds f64 bounds #1108

Closed dhable closed 1 week ago

dhable commented 3 weeks ago

Prior to this commit, string values that would exceed the f64 bounds would return f64::INFINITY. This leaks a type into the VRL scripts that could cause a panic without support to check for the value.

Fixes #1107

Summary

Change Type

Is this a breaking change?

How did you test this PR?

Does this PR include user facing changes?

Checklist

References

pront commented 1 week ago

Hi @dhable, thank you for this contribution. Do you plan to drive this PR to completion? Let me know if I can help.

dhable commented 1 week ago

@pront Yes, I just got back from PTO but I'll get the suggestions added.