parse_grok follows the Datadog Log's Grok algorithm's behavior where errors in applying filters are non fatal.
This change surfaces those filter errors to the caller, and differentiates between fatal and non fatal, as outlined by the Datadog Log's Grok algorithm, allowing the caller to decide whether to align with that or differ.
The stdlib parse_groks was unmodified, as such this is not a change to user facing behavior. If we decide to change that, we can do it in a follow up change.
Change Type
[ ] Bug fix
[ ] New feature
[x] Non-functional (chore, refactoring, docs)
[ ] Performance
Is this a breaking change?
[ ] Yes
[x] No
How did you test this PR?
Added/corrected unit tests
Does this PR include user facing changes?
[ ] Yes. Please add a changelog fragment based on
our guidelines.
[x] No. A maintainer will apply the "no-changelog" label to this PR.
Summary
parse_grok
follows the Datadog Log's Grok algorithm's behavior where errors in applying filters are non fatal. This change surfaces those filter errors to the caller, and differentiates between fatal and non fatal, as outlined by the Datadog Log's Grok algorithm, allowing the caller to decide whether to align with that or differ.The stdlib
parse_groks
was unmodified, as such this is not a change to user facing behavior. If we decide to change that, we can do it in a follow up change.Change Type
Is this a breaking change?
How did you test this PR?
Added/corrected unit tests
Does this PR include user facing changes?
Checklist
dd-rust-license-tool write
and commit the changes. More details here.References