search

vectordotdev / vrl

Vector Remap Language
Mozilla Public License 2.0
128 stars 59 forks source link

chore(tests): Use dns.google in dns_lookup tests instead of localhost #874

Closed jszwedko closed 3 months ago

jszwedko commented 3 months ago

localhost doesn't seem to resolve consistently on MacOS causing test failures locally. Certainly there is some risk relying on dns.google but it seems minimal. We can swap it out with another domain if/as needed. Failures can be seen here: https://github.com/vectordotdev/vrl/pull/875

Also updates the VRL test runner to correctly diff objects.

Easier to review with whitespace changes disabled since I changed the indentation when updating the fixtures.

jszwedko commented 3 months ago

cc/ @esensar in case you have any ideas on a better way to handle this.

esensar commented 3 months ago

cc/ @esensar in case you have any ideas on a better way to handle this.

I haven't tested on MacOS, but this is okay, I don't have an idea on how to do it differently.