search

vectorgraphics / asymptote

2D & 3D TeX-Aware Vector Graphics Language
https://asymptote.sourceforge.io/
GNU General Public License v3.0
542 stars 90 forks source link

Is the name orthocentercenter intentional or erroneous? #321

Closed jamadagni closed 2 years ago

jamadagni commented 2 years ago

In Asymptote, there are the functions orthocentercenter(triangle) and orthocentercenter(point, point, point):

https://github.com/vectorgraphics/asymptote/blob/587a21490bf6d3892ddeab36dc8d8acdd3cec32c/base/geometry.asy#L5719

https://github.com/vectorgraphics/asymptote/blob/587a21490bf6d3892ddeab36dc8d8acdd3cec32c/base/geometry.asy#L5387

However, to my limited knowledge and the less limited searching on Google, for a triangle there is no such thing as an “orthocentercenter”, only an “orthocenter”.

In fact Googling seems to lead to pages which actually only use this Asymptote code!

I am also not sure whether there is any reason that the function had to be called “orthocentercenter”.

While we may need to retain the doubled name for backward compatibility, isn't it time for the simple straightforward actual name of “orthocenter” to be provided?

ivankokan commented 2 years ago

Something that has been on my mind for 13 years at least, but have never asked. :)

orthocenter + keeping things backward-compatible should be the way to go.