Closed yarusome closed 1 year ago
Btw, the geometry
module contains a lot of asyxml
tags, which form a large part of the source code and seem to be used for documentation. However, it's the only module that has such tags, so I guess these tags are no longer needed. If so, I'd create another PR to clean them up.
Btw, the
geometry
module contains a lot ofasyxml
tags, which form a large part of the source code and seem to be used for documentation. However, it's the only module that has such tags, so I guess these tags are no longer needed. If so, I'd create another PR to clean them up.
Please do not. Check this, still on my TODO list...
@ivankokan I'll leave them there, then. But beware that there're various incorrect signatures and format inconsistency in these tags.
These errors need to be fixed:
asy
import geometry;
point Ap = inverse(k, A, s.A), Bp = inverse(k, A, s.B),
^
base/geometry.asy: 7157.21: no matching function 'inverse(real, point, point)'
point Ap = inverse(k, A, s.A), Bp = inverse(k, A, s.B),
^
base/geometry.asy: 7157.46: no matching function 'inverse(real, point, point)'
M = inverse(k, A, midpoint(s));
^
base/geometry.asy: 7158.16: no matching function 'inverse(real, point, point)'
@johncbowman Fixed, and no other incorrect use of inverse()
remains now.
@johncbowman Would this PR be merged soon? It has been sitting here for months. If there're any pending problems in this PR, I could fix them as soon as possible.
This PR fixes bugs related to coordinate systems in the inversion section of the
geometry
module, and simplifies the internal use ofinversion
.