Closed user202729 closed 2 weeks ago
Instead, it can just always assume above=true.
above=true
If the caller wants above=false, it can create a new frame and prepend it to the resulting frame itself.
above=false
Currently it needlessly duplicate the following code across the 3 types of boxes
frame F; if(above == false) { filltype.fill(F,g,p); prepend(dest,F); } else filltype.fill(dest,g,p);
Thought?
A better idea that avoids breaking existing code is in commit c7f016286dffc4cd1805d7541d50e17d05805527.
Instead, it can just always assume
above=true
.If the caller wants
above=false
, it can create a new frame and prepend it to the resulting frame itself.Currently it needlessly duplicate the following code across the 3 types of boxes
Thought?