search

vectorgrp / sil-kit

Vector SIL Kit – Open-Source Library for Connecting Software-in-the-Loop Environments
https://vectorgrp.github.io/sil-kit-docs
MIT License
100 stars 28 forks source link

tests: remove MakeTestRegistryUri #101

Closed MariusBgm closed 2 weeks ago

MariusBgm commented 2 weeks ago

remove the MakeTestRegistryUri function from all tests. Use the dynamically allocated registry port instead.

MariusBgm commented 2 weeks ago

Only 2 minor remarks:

1. Clang Format: The CI shows 6 files, which are not formatted correctly (warnings).

2. For an entire cleanup w.r.t. the MakeTestRegistryUri() method, you could consider removing the (now obsolete) header `include "GetTestPid.hpp"` from the ITests.

Thanks for having a look. I removed the GetTestPid.hpp where possible. Not sure about clang-format, I'll have to investigate why it doesn't format those files for me (later).