search

vectorgrp / sil-kit

Vector SIL Kit – Open-Source Library for Connecting Software-in-the-Loop Environments
https://vectorgrp.github.io/sil-kit-docs
MIT License
107 stars 32 forks source link

Log file timestamp granularity #131

Closed kocho1984 closed 1 month ago

kocho1984 commented 1 month ago

Hi,

Could you please consider to change the format of a timestamp which is added to log file name? Currently, it has a second granularity.

What will happen if two participants that use the same config file are created at the same second? Will they share the same log file? I think that miliseconds granularity would be safer in such cases.

VDanielEdwards commented 1 month ago

Hello @kocho1984, thank you for posting this issue.

This is an issue that we have faced before as well, if multiple participants are started in the same process in quick succession. We've recently been discussing this internally.

MariusBgm commented 1 month ago

@kocho1984 @VDanielEdwards I just merged something that should fix this issue temporarily: https://github.com/vectorgrp/sil-kit/pull/132 We now add the participant's name to the log file's name.

VDanielEdwards commented 1 month ago

@kocho1984 and PR #132 has just been merged.