vectorgrp / sil-kit

Vector SIL Kit – Open-Source Library for Connecting Software-in-the-Loop Environments
https://vectorgrp.github.io/sil-kit-docs
MIT License
107 stars 32 forks source link

Fix flakey ITest_Abort #24

Closed KonradBkd closed 7 months ago

KonradBkd commented 7 months ago

Subject

The subtest test_Abort_Stopped_Simulation_Sync in ITest_Abort is flakey and possibly fails (locally reproducible on clang-release builds after several iterations).

The test had wrong expectations for the emerging ParticipantStates: In the test, the system controller stops the simulation and aborts in the stop handler. However it can happen that a participant is done with the stop before the abort arrives.

This is fixed by extending the expectations for the participants states that can emerge on a valid path from stop->shutdown.