search

vectorgrp / sil-kit

Vector SIL Kit – Open-Source Library for Connecting Software-in-the-Loop Environments
https://vectorgrp.github.io/sil-kit-docs
MIT License
107 stars 32 forks source link

Extended Id j1939 messages not working with sil-kit on canoe #54

Closed RodrigoBaumann-hub closed 4 months ago

RodrigoBaumann-hub commented 4 months ago

Hi, I'm trying to communicate J1939 messages with SIL-KIT, but every time I send a message, the ID gets truncated. For example: vcan2 400 [8] C0 00 00 00 00 F0 FF 00 Also, when I send a message from WSL to Canoe with an extended ID like this: cansend vcan2 18FDE5FF#13140003FF00660101

I get this error:

[E] [System] 83-0203 CAN frame with invalid format received on channel CAN 7.

What could the solution be? Is it an issue with Canoe's configuration or SIL-KIT?

VDanielEdwards commented 4 months ago

Hello @RodrigoBaumann-hub, thank you for your message!

I'm investigating your issue!

VDanielEdwards commented 4 months ago

Hello @RodrigoBaumann-hub, thanks to your report we have found a bug in the sil-kit-adapters-vcan project.

I created a PR in the sil-kit-adapters-vcan repository that addresses the issue that CANoe received invalid CAN frames and aborts the measurement.

VDanielEdwards commented 4 months ago

@RodrigoBaumann-hub, regarding the other issue, where CAN IDs get truncated: could you provide us with the 'original' frame, and the 'transformed' frame with the truncated ID?

Additionally, could you describe your setup a little bit, i.e., are you using SIL Kit in your own application, and/or other software?

VDanielEdwards commented 4 months ago

@RodrigoBaumann-hub, we believe that we have found the other problem as well. Please don't be confused if the PR on the sil-kit-adapters-vcan repository is closed without merging - the issues are handled internally!

RodrigoBaumann-hub commented 4 months ago

Thank you @VDanielEdwards If I send 0x18FECC00 AA BB CC DD EE FF 11 22 via Canoe and receive it on WSL, I get: vcan2 400 [8] AA BB CC DD EE FF 11 22 However, the ID is truncated. I'm working with a network on Canoe that sends J1939 messages and also forwards them via SIL-KIT to vcan2 on WSL.

VSvenMorgenthaler commented 4 months ago

@RodrigoBaumann-hub (CC: @VDanielEdwards): The issue has been solved on: https://github.com/vectorgrp/sil-kit-adapters-vcan/commit/65eec259d5c159b318dc54ba5ee6e97c9fb5ba3b

VDanielEdwards commented 4 months ago

Closing this issue due to inactivity. Please feel free to reopen this, if required.