vectorgrp / sil-kit

Vector SIL Kit – Open-Source Library for Connecting Software-in-the-Loop Environments
https://vectorgrp.github.io/sil-kit-docs
MIT License
107 stars 32 forks source link

SILKIT-1525: Use bulk-update endpoint of dashboard backend service #71

Closed VDanielEdwards closed 4 months ago

VDanielEdwards commented 4 months ago

Subject

These changes allow the dashboard client in SIL Kit to use the bulk-update endpoint (currently only available in a feature branch of the dashboard that is not publically available).

It allows for much larger simulations, as multiple changes can be combined into a single HTTP request.

Instructions for review / testing

Developer checklist (address before review)

VDanielEdwards commented 4 months ago

NOTE: The branch was rebased onto the (soon-to-be-merged) branch dev_disable_broken_ubuntu1804_uploads from PR-73. Therefore, there will be a final rebase onto main after that one was merged.

VDanielEdwards commented 4 months ago

Hab ich richtig gesehen, dass die Optimierung nur über ExperimentalEnableDashboardBulkUpdates in der Konfigdatei aktivierbar ist und über CLI immer aus ist? Dann dokumentiere ich es so im Dashboard README. :)

I'm likely going to get some feedback from stakeholders today, so it's probably best if you wait until afternoon 👍 @NadegeNag

VDanielEdwards commented 4 months ago

@VDanielEdwards Note-to-Self: Check where the registry configuration schema is located and maintained (it is available in the schema store, but not in the sil-kit repository ?).

VDanielEdwards commented 4 months ago

@KonradBkd we replaced the flag with auto-detection of the bulk-update availability. The code has been streamlined slightly.

VDanielEdwards commented 4 months ago

LGTM (except the obsolete comment)

Also removed the obsolete documentation changes, and reworded the changelog entry.