vectorgrp / sil-kit

Vector SIL Kit – Open-Source Library for Connecting Software-in-the-Loop Environments
https://vectorgrp.github.io/sil-kit-docs
MIT License
107 stars 32 forks source link

config: add separate cache for stdout/remote sinks #75

Closed VJanKraemer closed 3 months ago

VJanKraemer commented 3 months ago

Subject

The current implementation had a bug, which prohibited a user from adding a remote and a stdout sink at the same time to a participant. The bug was fixed by adding separate caches for each logging sink type.

Instructions for review / testing

Build the CanDemo. Run the CanDemo with the folloging logging Config:

Logging: Sinks:

  • Type: Remote Level: Trace LogName: CanWriterLog
  • Type: Stdout Level: Trace LogName: CanWriterLog

Developer checklist (address before review)

VJanKraemer commented 3 months ago

The changes look good to me! 👍 Could you add a simple unit-test to make sure duplicates result in an error during merges and merged sinks are included in the final config?

Sure thing, this is a good idea 👍