vectorgrp / vector-vscode-vcast

A VectorCAST test adapter for VS Code
Other
7 stars 3 forks source link

Run tsc before running vitest #151

Closed aytey closed 2 months ago

aytey commented 2 months ago

Tests are now type-checked with tsc before running vitest.

In the coded_mock branch, we would have received:

tests/unit/utils.ts:135:31 - error TS2345: Argument of type 'TextDocuments' is not assignable to parameter of type 'TextDocument'.
  Type 'TextDocuments' is missing the following properties from type 'TextDocument': uri, languageId, version, getText, and 3 more.

135   return getTstCompletionData(documents, completion);

and the tests wouldn't have run.

github-actions[bot] commented 2 months ago

Unit Test results

 1 files  ±0   5 suites  ±0   4s :stopwatch: ±0s 43 tests ±0  43 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  44 runs  ±0  44 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 23 - Group flask_icon

9 tests  ±0   9 :white_check_mark: ±0   2m 2s :stopwatch: -2s 1 suites ±0   0 :zzz: ±0  1 files   ±0   0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.44%. Comparing base (ccf4c73) to head (cade431).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #151 +/- ## ======================================= Coverage 84.44% 84.44% ======================================= Files 6 6 Lines 958 958 Branches 125 125 ======================================= Hits 809 809 Misses 24 24 Partials 125 125 ``` | [Flag](https://app.codecov.io/gh/vectorgrp/vector-vscode-vcast/pull/151/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vectorgrp) | Coverage Δ | | |---|---|---| | [Unit](https://app.codecov.io/gh/vectorgrp/vector-vscode-vcast/pull/151/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vectorgrp) | `84.44% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vectorgrp#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 23 - Group bugs

 2 files  ±0   2 suites  ±0   4m 4s :stopwatch: -7s 12 tests ±0  12 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  14 runs  ±0  14 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 23 - Group func_basis

2 files  ±0  2 suites  ±0   2m 25s :stopwatch: -3s 7 tests ±0  7 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  9 runs  ±0  9 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 23 - Group unit_basis

2 files  ±0  2 suites  ±0   3m 32s :stopwatch: -27s 7 tests ±0  7 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  9 runs  ±0  9 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 23 - Group env_basis

2 files  ±0  2 suites  ±0   7m 58s :stopwatch: -27s 7 tests ±0  7 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  9 runs  ±0  9 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 24 - Group bugs

 2 files  ±0   2 suites  ±0   4m 58s :stopwatch: +16s 12 tests ±0  12 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  14 runs  ±0  14 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

aytey commented 2 months ago

@SalvatoreZagaria: if npm test fails, what happens to GHA?

To clarify: this isn't vitest failing, this npm test giving a non-zero return code -- does this fail the tests when viewed by GHA? If not, can we make that happen?

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 23 - Group basic_user_interactions

 9 files  ±0   9 suites  ±0   11m 2s :stopwatch: -20s 25 tests ±0  25 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  43 runs  ±0  43 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 24 - Group coded_tests

 1 files  ±0   1 suites  ±0   6m 8s :stopwatch: -35s 16 tests ±0  16 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  17 runs  ±0  17 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 24 - Group flask_icon

9 tests  ±0   9 :white_check_mark: ±0   2m 30s :stopwatch: -3s 1 suites ±0   0 :zzz: ±0  1 files   ±0   0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 24 - Group func_atg

2 files  ±0  2 suites  ±0   2m 16s :stopwatch: -1s 7 tests ±0  7 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  9 runs  ±0  9 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 24 - Group env_atg

2 files  ±0  2 suites  ±0   6m 46s :stopwatch: -14s 7 tests ±0  7 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  9 runs  ±0  9 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 24 - Group basic_user_interactions

 9 files  ±0   9 suites  ±0   10m 38s :stopwatch: -30s 25 tests ±0  25 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  43 runs  ±0  43 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 24 - Group env_basis

2 files  ±0  2 suites  ±0   7m 58s :stopwatch: -26s 7 tests ±0  7 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  9 runs  ±0  9 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 24 - Group func_basis

2 files  ±0  2 suites  ±0   2m 25s :stopwatch: +3s 7 tests ±0  7 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  9 runs  ±0  9 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 24 - Group unit_atg

2 files  ±0  2 suites  ±0   2m 46s :stopwatch: -12s 7 tests ±0  7 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  9 runs  ±0  9 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

github-actions[bot] commented 2 months ago

E2e Test results - Vcast 24 - Group unit_basis

2 files  ±0  2 suites  ±0   3m 37s :stopwatch: -13s 7 tests ±0  7 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  9 runs  ±0  9 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit cade431a. ± Comparison against base commit ccf4c731.

aytey commented 2 months ago

@SalvatoreZagaria: if npm test fails, what happens to GHA?

To clarify: this isn't vitest failing, this npm test giving a non-zero return code -- does this fail the tests when viewed by GHA? If not, can we make that happen?

I guess it will fail, based on https://github.com/vectorgrp/vector-vscode-vcast/pull/153