Closed aytey closed 2 months ago
1 files ±0 5 suites ±0 4s :stopwatch: ±0s 43 tests ±0 43 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 44 runs ±0 44 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
9 tests ±0 9 :white_check_mark: ±0 2m 2s :stopwatch: -2s 1 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.44%. Comparing base (
ccf4c73
) to head (cade431
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
2 files ±0 2 suites ±0 4m 4s :stopwatch: -7s 12 tests ±0 12 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 14 runs ±0 14 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
2 files ±0 2 suites ±0 2m 25s :stopwatch: -3s 7 tests ±0 7 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 9 runs ±0 9 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
2 files ±0 2 suites ±0 3m 32s :stopwatch: -27s 7 tests ±0 7 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 9 runs ±0 9 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
2 files ±0 2 suites ±0 7m 58s :stopwatch: -27s 7 tests ±0 7 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 9 runs ±0 9 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
2 files ±0 2 suites ±0 4m 58s :stopwatch: +16s 12 tests ±0 12 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 14 runs ±0 14 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
@SalvatoreZagaria: if npm test
fails, what happens to GHA?
To clarify: this isn't vitest
failing, this npm test
giving a non-zero return code -- does this fail the tests when viewed by GHA? If not, can we make that happen?
9 files ±0 9 suites ±0 11m 2s :stopwatch: -20s 25 tests ±0 25 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 43 runs ±0 43 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
1 files ±0 1 suites ±0 6m 8s :stopwatch: -35s 16 tests ±0 16 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 17 runs ±0 17 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
9 tests ±0 9 :white_check_mark: ±0 2m 30s :stopwatch: -3s 1 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
2 files ±0 2 suites ±0 2m 16s :stopwatch: -1s 7 tests ±0 7 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 9 runs ±0 9 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
2 files ±0 2 suites ±0 6m 46s :stopwatch: -14s 7 tests ±0 7 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 9 runs ±0 9 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
9 files ±0 9 suites ±0 10m 38s :stopwatch: -30s 25 tests ±0 25 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 43 runs ±0 43 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
2 files ±0 2 suites ±0 7m 58s :stopwatch: -26s 7 tests ±0 7 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 9 runs ±0 9 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
2 files ±0 2 suites ±0 2m 25s :stopwatch: +3s 7 tests ±0 7 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 9 runs ±0 9 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
2 files ±0 2 suites ±0 2m 46s :stopwatch: -12s 7 tests ±0 7 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 9 runs ±0 9 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
2 files ±0 2 suites ±0 3m 37s :stopwatch: -13s 7 tests ±0 7 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 9 runs ±0 9 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0
Results for commit cade431a. ± Comparison against base commit ccf4c731.
@SalvatoreZagaria: if
npm test
fails, what happens to GHA?To clarify: this isn't
vitest
failing, thisnpm test
giving a non-zero return code -- does this fail the tests when viewed by GHA? If not, can we make that happen?
I guess it will fail, based on https://github.com/vectorgrp/vector-vscode-vcast/pull/153
Tests are now type-checked with
tsc
before runningvitest
.In the coded_mock branch, we would have received:
and the tests wouldn't have run.