search

vectorgrp / vector-vscode-vcast

A VectorCAST test adapter for VS Code
Other
8 stars 2 forks source link

Changed expected error code for compileError. #199

Closed Den1552 closed 2 months ago

Den1552 commented 2 months ago

Summary

This PR is related to vectorgrp/vector-vscode-vcast#198. It contains a small change in the source code to fix issues when retrieving compile errors.

Den1552 commented 2 months ago

Explanation

The issue occurs in this line:

https://github.com/vectorgrp/vector-vscode-vcast/blob/c4d4050af100e4571346010cd44d9b058ed9727a/src/vcastTestInterface.ts#L449

When a compileErroris encountered, we expect an error message to appear for the user and the ACOMPILE.LIS to open. However, neither of these actions is happening, which is why the spec group coded_tests is failing.

The root cause is that when a compile error occurs, the expected error code (pythonErrorCodes.codedTestCompileError (996)) is not being returned. Instead, the error code returned is 228. As a result, the returnStatusis incorrectly set to didNotRun.

https://github.com/vectorgrp/vector-vscode-vcast/blob/c4d4050af100e4571346010cd44d9b058ed9727a/src/vcastTestInterface.ts#L465C5-L465C41

This causes the TextMessage to not be displayed:

https://github.com/vectorgrp/vector-vscode-vcast/blob/75b08eee8fe72530a5a295fbea8413bbd6c9d181/src/testPane.ts#L853-L856

Ultimately, this leads to the failure of the coded_tests spec group.

aytey commented 2 months ago

This is not the correct fix.

See https://github.com/vectorgrp/vector-vscode-vcast-internal/issues/1