search

vectorlit / UnofficialGenconMobile

Code for Unofficial Gen Con Mobile application - Xamarin version.
GNU General Public License v3.0
3 stars 3 forks source link

Feature/Bug Fix: Modernize Toast/Popup methods #4

Open vectorlit opened 5 years ago

vectorlit commented 5 years ago

Currently we use static method GlobalVars.DoToast in order to open a toast on the main thread. The goal of this feature/bug fix is to change these toasts to appear in a more convenient location for the user.

Currently the toasts ("Checking for updated events... " or "Update Success" etc) cause a lot of confusion among users of the application. They block part of the screen, and although their on-screen time is rarely more than a few seconds, I have received many reports that users feel the app is "broken" because these toasts appear. Specifically, iOS was a big culprit because the toasts block the tab selection at the bottom of the screen.

So this feature/bug fix is to investigate and make the toasts no longer block vital areas of the screen. It would be nice to also conform to modern material design cues as well, but functionality is more important.

Currently an older version of the ACR User Dialogs plugin is being used, but it should be evaluated if this is still the correct decision. Originally the decision was made to use this plugin due to compatibility with older devices on iOS. Please consider that for 2019, we plan to support ALL the same models we supported in 2018 (no iOS or Android updated version requirements).

This was the most commonly reported "issue" in 2018.

garkenxian commented 5 years ago

i'll take this one as well. the idea here is to update the tab view to something a bit less restrictive (looking at you sharpnado/"Pure" Xamarin.Forms tabs) which will allow us to better control the UI

vectorlit commented 5 years ago

Latest requests (#13) and https://github.com/vectorlit/UnofficialGenconMobile/commit/45ca3623536d8b6325aa3f765185810b737a7b3f followup have added changes that support this, but not totally done. Marking as in progress

vectorlit commented 5 years ago

This has been halfway implemented. Many toasts still appear in the old system - they need to be migrated to the new system, and ensure that they appear on screen even when popups are visible. Leaving in progress but changing to medium priority for 2020.