From [EMI 1.1.0+1.20.1+forge] Percentaged output in recipe tree

[ghost]

Minecraft version

1.20.1

Farmer's Delight version

1.2.4

Forge version

47.2.17

Description

An issue from emi's page. They told me the following is a bug with Farmers Delight: EMI indicates in the recipe that an item has a probability (here 50%) for the recipe (here cutting board) as an output. But in the recipe tree it doesn't show ~8 (4/50%) wild rice like in the fabric version.

https://github.com/emilyploszaj/emi/issues/432

Steps to reproduce

Open the inventory Look for a recipe with a percentaged output like shovel-digging gravel on a cutting board (did you want the duplication-glitch?) Press the button with the four squares next to the recipe. Adjust the batch size. The leftovers (flint) are always as many as gravel, but the should be a tenth. The same if you wanna make a flint knife for example and choose for the cutting recipe the are not 10 gravel but 1 gravel.

Mod list

Create 1.20.1-0.5.1.f (has also this problem) EMI 1.1.0+1.20.1+forge Farmer's Delight 1.20.1-1.2.4 Just Enough Items 15.3.0.1 (without it the recipes weren't visible)

Logs

No response

Minimal instance

• [X] I have tested this on a minimal instance

Performance and shader mods

• [ ] I am using performance or shader mods

[MerchantPug]

This would mean that EMI integration would have to be a thing. Which I'm unsure if vectorwing wants to do due to slightly more maintenance work.

If vectorwing so pleases, I'd be happy to PR the integration from Farmer's Delight Refabricated over here, it should be the exact same implementation between the two.

[MerchantPug]

This is simply a thing that JEMI (The JEI compat layer) does not support, as JEI has no built-in output chance like EMI does.

[Kevin-Marsh]

Could this be a thing implemented into Farmers delight? A few mods have dropped JEI support in 1.21 which has lead packs like ATM10 and Enigmatica 10 to implement EMI. ATM10 is also trying to run without JEMI so built in EMI compatibility would be amazing.

[vectorwing]

Hmm... I'm unsure how many more plugins I'm interested in adding to FD natively, as they tend to be pain points during porting.

Is it possible to only implement the code necessary for chance results to be calculated (while using the JEI plugin), or would I need to write a fully-fledged plugin for EMI? I need to measure the maintenance here before I consider it.

[Kevin-Marsh]

EMI would require a separate plugin to be implemented for native compatability. I am unsure of the difficulty in doing so but I personally believe native EMI compat could be a benefit going forward with more mods implementing it.

[MerchantPug]

You are free to use Farmer's Delight Refabricated as a reference to see an example of how different it'd be to implement a native EMI plugin.

https://github.com/MehVahdJukaar/FarmersDelight/tree/1.20/src/main/java/vectorwing/farmersdelight/integration/emi